-
Notifications
You must be signed in to change notification settings - Fork 24
Round 2: add spice removal, qemu, livrit, virtioFS, split to articles #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
WIP, do not merge yet. |
|
Antoine, please do not use the underscore in element IDs. The only allowed delimiter is a dash, with anything the build will fail. Thanks! |
ok, no problem, i will take that into account. |
This reverts commit 59976f3.
|
@lvicoun you can merge it. |
lvicoun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Souvik,
I did a very brief review as there were no structural changes. But in general - the assemblies titles are the same for all articles and misaligned with the metadata title. SLED is a discontinued product, so no profiling nor reference should be there. The SUSE Linux Enterprise or the abbreviated form is not allowed for the 16 codebase so use the suselinux entity. In section titles there must be the sentence style capitalization, I fixed several of them but left most of them as it is, but it needs to be fixed.
Co-authored-by: lvicoun <JSindelarova@suse.com>
Co-authored-by: lvicoun <JSindelarova@suse.com>
Co-authored-by: lvicoun <JSindelarova@suse.com>
Co-authored-by: lvicoun <JSindelarova@suse.com>
Co-authored-by: lvicoun <JSindelarova@suse.com>
Co-authored-by: lvicoun <JSindelarova@suse.com>
Co-authored-by: lvicoun <JSindelarova@suse.com>
|
I let you @lvicoun fix the conflict before merge |
PR creator: Description